UPGRADE YOUR SKILLS: Learn advanced Swift and SwiftUI on Hacking with Swift+! >>

Project 4, Challenge 1: Always getting "Blocked" on apple.com

Forums > 100 Days of Swift

Here's the code I have

    func webView(_ webView: WKWebView, decidePolicyFor navigationAction: WKNavigationAction, decisionHandler: @escaping (WKNavigationActionPolicy) -> Void) {
        let url = navigationAction.request.url

        if let host = url?.host {
            for website in websites {
                if host.contains(website) {
                    decisionHandler(.allow)
                    return
                }
            }
        } else {
            let ac = UIAlertController(title: "Blocked", message: "You are not allowed", preferredStyle: .alert)
            ac.addAction(UIAlertAction(title: "Continue", style: .default, handler: nil))
            present(ac, animated: true)
            decisionHandler(.cancel)
        }
    }

The problem is that when apple.com loads, the "Blocked" alert always fires. If I dismiss it, everything is cool.

How can I debug this?

3      

This way should resolve the issue.

    func webView(_ webView: WKWebView, decidePolicyFor navigationAction: WKNavigationAction, decisionHandler: @escaping (WKNavigationActionPolicy) -> Void) {

        let url = navigationAction.request.url

        let ac = UIAlertController(title: "Alert", message: "URL is not allowed.", preferredStyle: .alert)
        ac.addAction(UIAlertAction(title: "Cancel", style: .destructive))

        if let host = url?.host {
            for website in websites {
                if host.contains(website) {
                    decisionHandler(.allow)
                    return
                }
            }
        }

        if !webView.isLoading {
            present(ac, animated: true)
        }
        decisionHandler(.cancel)
    }

3      

OK, that does work, but how does it work? Why if !webview.isLoading ?

3      

I am not specialist in WebKit Framework :) cannot really recall how i came up with this solution now in details however webview.isLoading checks whether the view is loading new content or not. So if it is not loading we can present alert to a user.

Your code actually works but there is a caveat. apple.com has regional settings/or other settings or whatever it is called so when you type in in the search bar of the browser apple.com it might redirect you to your region or make other actions behind the scenes that is why you have your alert triggered for that particular site but not for hackingwithswift.com. Should you put any other site that doesn't do the same as apple.com it will work fine.

Using webview.isLoading we can check if loading is happening at all, and if it is not we trigger alert, so kind of avoding this behavior.

Hope that helps :)

PS. With this modification it won't crash your code. As in your code if you replace apple.com with yahoo.com it just crashes.

if let host = url?.host {
            for website in websites {
                if host.contains(website) {
                    decisionHandler(.allow)
                    return
                }
            }
        } else {
            let ac = UIAlertController(title: "Blocked", message: "You are not allowed", preferredStyle: .alert)
            ac.addAction(UIAlertAction(title: "Continue", style: .default, handler: nil))
            present(ac, animated: true)
        }
decisionHandler(.cancel)

with yahoo.com is the same thing as with apple.com. However google.com is working fine. Also that will not trigger an alert if you try to navigate from within allowed sites to another site, but view.Loading you can handle this.

3      

Hacking with Swift is sponsored by Essential Developer

SPONSORED Join a FREE crash course for mid/senior iOS devs who want to achieve an expert level of technical and practical skills – it’s the fast track to being a complete senior developer! Hurry up because it'll be available only until April 28th.

Click to save your free spot now

Sponsor Hacking with Swift and reach the world's largest Swift community!

Reply to this topic…

You need to create an account or log in to reply.

All interactions here are governed by our code of conduct.

 
Unknown user

You are not logged in

Log in or create account
 

Link copied to your pasteboard.