NEW: Subscribe to Hacking with Swift+ and accelerate your learning! >>

How to fix “Modifying state during view update, this will cause undefined behavior”

Paul Hudson    @twostraws   

Updated for Xcode 12.0

This error occurs because you’re modifying the state of a SwiftUI view while the view is actually being rendered. Modifying the state of a view causes the view to be re-rendered, so SwiftUI gets confused – “undefined behavior” is Apple’s way of saying that whatever you see right now might change in the future because it’s not how SwiftUI should be used.

Here’s an example of the problem in action:

struct ContentView: View {
    @State private var name = ""

    var body: some View {
        if name.isEmpty {
            name = "Anonymous"
        }

        return Text("Hello, \(name)!")
    }
}

That creates a state property called name, and has a text view that shows it. However, inside body is some logic that attempts to modify name while the view is being rendered – SwiftUI is trying to figure out what’s in the view, and you’re changing it while that process is happening.

To fix the problem, move the code that changes your view’s state – in this case the name = "Anonymous" – to something that occurs outside of the view updates. For example, this sets the value when the text view first appears:

struct ContentView: View {
    @State var name = ""

    var body: some View {
        Text("Hello, \(name)!")
            .onAppear {
                if self.name.isEmpty {
                    self.name = "Anonymous"
                }
            }
    }
}

You could also move the logic into an onTapGesture() or similar – anywhere that isn’t directly inside the body of a view.

Hacking with Swift is sponsored by NSSpain

SPONSORED Announcing NSSpain 2020: Remote Edition! An online, continuous conference for iOS developers. We’ll start on Thursday and finish on Friday, with talks, activities, and lots of fun for 36 hours, non-stop. Sound good? Join us!

Find out more

Sponsor Hacking with Swift and reach the world's largest Swift community!

Similar solutions…

BUY OUR BOOKS
Buy Pro Swift Buy Swift Design Patterns Buy Testing Swift Buy Hacking with iOS Buy Swift Coding Challenges Buy Swift on Sundays Volume One Buy Server-Side Swift (Vapor Edition) Buy Advanced iOS Volume One Buy Advanced iOS Volume Two Buy Advanced iOS Volume Three Buy Hacking with watchOS Buy Hacking with tvOS Buy Hacking with macOS Buy Dive Into SpriteKit Buy Swift in Sixty Seconds Buy Objective-C for Swift Developers Buy Server-Side Swift (Kitura Edition) Buy Beyond Code

Was this page useful? Let us know!

Average rating: 3.3/5

Link copied to your pasteboard.