NEW: Nominations are now open for the 2019 Swift Community Awards! >>

How to fix “Modifying state during view update, this will cause undefined behavior”

Paul Hudson    @twostraws   

Fully updated for Xcode 11.1

This error occurs because you’re modifying the state of a SwiftUI view while the view is actually being rendered. Modifying the state of a view causes the view to be re-rendered, so SwiftUI gets confused – “undefined behavior” is Apple’s way of saying that whatever you see right now might change in the future because it’s not how SwiftUI should be used.

Here’s an example of the problem in action:

struct ContentView: View {
    @State private var name = ""

    var body: some View {
        if name.isEmpty {
            name = "Anonymous"
        }

        return Text("Hello, \(name)!")
    }
}

That creates a state property called name, and has a text view that shows it. However, inside body is some logic that attempts to modify name while the view is being rendered – SwiftUI is trying to figure out what’s in the view, and you’re changing it while that process is happening.

To fix the problem, move the code that changes your view’s state – in this case the name = "Anonymous" – to something that occurs outside of the view updates. For example, this sets the value when the text view first appears:

struct ContentView: View {
    @State var name = ""

    var body: some View {
        Text("Hello, \(name)!")
            .onAppear {
                if self.name.isEmpty {
                    self.name = "Anonymous"
                }
            }
    }
}

You could also move the logic into an onTapGesture() or similar – anywhere that isn’t directly inside the body of a view.

SAVE 20% ON iOS CONF SG The largest iOS conference in Southeast Asia is back in Singapore for the 5th time in January 2020, now with two days of workshops plus two days of talks on SwiftUI, Combine, GraphQL, and more! Save a massive 20% on your tickets by clicking on this link.

Similar solutions…

MASTER SWIFT NOW
Buy Testing Swift Buy Practical iOS 12 Buy Pro Swift Buy Swift Design Patterns Buy Swift Coding Challenges Buy Server-Side Swift (Vapor Edition) Buy Server-Side Swift (Kitura Edition) Buy Hacking with macOS Buy Advanced iOS Volume One Buy Advanced iOS Volume Two Buy Hacking with watchOS Buy Hacking with tvOS Buy Hacking with Swift Buy Dive Into SpriteKit Buy Swift in Sixty Seconds Buy Objective-C for Swift Developers Buy Beyond Code

Was this page useful? Let us know!