Im starting to learn SwiftUI a month ago and now i create an App. Would anyone be willing to watch my code and make a review? I posted code in GitHub (https://github.com/Spich3000/stonksProfitCalculator-1.01).

Thanks in advance!

Hi Dimitry

Welcome to this forum and good luck learning SwiftUI. I think Hacking With Swift is a really great resource. Keep on learning!

I looked at your source code and have the following suggestions for improvements:

• Try splitting up your app into multiple views. Currently you only have ContentView defined. All your tabs (you have 4) should go into their separate Views along with the correspinding @State variables (perhaps even put them in their own file). You can try to the content of each tab as if it was a single screen.

• You could write a ClearableTextField view and reuse it wherever you have

  TextField(..., text: ...)
    .modifier(TextFieldClearButton(text: ...))

  Basically, whenever you see code duplicated multiple time, you might ask "can I somehow make a component which can be reused?" You already did this by writing some ViewModifiers, but in this case a dedicated View would be much better.

• Your approach to localization is somehow "unique" :-). Do you know by heart what localization(index: 6) or do you find yourself looking up the entry in the array? To improve on this, I recommend you: decide what's your development language and write all the localizable texts as plain String litterals in your code. TextField("Enter quantity of token", text: $quantityOfToken) instead of TextField(localization(index: 6), text: $quantityOfToken)

  Then add a Localizable.strings source to your project with the strings which are going to be shown in the UI:

  "Enter quantity of token" = "Enter quantity of token";

  See also How to localize your iOS app

@pd95 Thank you so much! I will try to fix this as soon as possible. This is really helpfull cause i dont know how to write code right. Hope i can figure out how to handle it :3 Thank you again!

@NigelGee Wow! Great thanks for you! Thats a lot of work, thank you so much :3

I finished today with localization: add Russian and Ukranian, but how can i select language manualy? When i build app it shows language based on a system region. But i want English.

1. Can you explain about refactor code to a multiple Files in Xcode? It is for easy reading code? Or its one of the patern of programming?

2. I tried with: format: .number it didn't work in my code. I would try with it again its really simplified formulas.

3. You are right! This is for decimalPad in Russian location. But how can i handle coma in this case?

   // Replace "," with "." function

   func convert(text: String) -> String { let conversion = text.replacingOccurrences(of: ",", with: ".") return conversion }

4. Yes i got it with localization, but for what is this ("%@" = "%@";)? I dont clearly understand what for is it? This is format or something?

I was searching for a week to find review and finaly found this beautiful site! Really hard learning alone, but its so cool to find out how all this things works. Thank you so much for your help <3

@Spich3000 I will try to give some answer for your points.

1. Putting code into files make it easy to find the code you want. (think of it as a file cabinet, if everything was in one file then you would take along time to find the piece of paper that you needed). It also make each code sample smaller so easy to read.
2. You need to use TextField that use value not text. If you just added format: .number to the end of your TextField then it will not work. Also the @State var need to be a number (Double or Int)
3. You do not need to handle comma as if the App Language is set to Russian then Apple handle it.
4. "%@" = "%@" This is for the Text like Text("\(percentageDifference, format: .percent)") etc. However if you had something like Text("The pencentage is \(percentageDifference, format: .percent)") then you would need this

   "The pencentage is %@" = "The pencentage is  %@"

Regarding the English version best is to add the English Localization (same as when you added Ukranian) then when you do Option Run you can select the English version and this will stay until you change it.

PS if you run a real device you can select the Language that the App run in to.

I would recomend that you do 100 Days of SwiftUI, It a great course and some of these question might be clearer.

PSS you can alway download my project from GitHub and look at the code I did if something does not work

Have fun and happy coding

@NigelGee Oh i got it. I will try see into with your code. Already subcribe to your Git acc :-) Thank you so much!

@NigelGee How can i bind FocusState variable in ContentView with other views? I see in concole that when i press button in toolbar, focus changed to false, but its not going to other views where i need to close keyboard.

I handle it with UIKit:

import SwiftUI
import UIKit

struct HideKeyboard: ViewModifier {
    func body(content: Content) -> some View {
        content
        Button("Done") {
            UIApplication.shared.sendAction(#selector(UIResponder.resignFirstResponder), to: nil, from: nil, for: nil)
        }
    }
}

extension View {
    var hideKeyboard: some View {
        modifier(HideKeyboard())
    }
}

And then add .hideKeyboard to button action in toolbar. Now it all works. Im starting to try remove my convert func and testing app <3

I tried to change format to .number in TextField inputs and it's not working right:

1. You are always starting write number with 0. Always needed to delete it at first.
2. You cant see the keyTitle, cause of "0".
3. ClearButton doesnt work properly, value always stays while editting.

I tried my convert function on a UK region (switch my phone to United Kindom region, and British English language). App works fine like i planed! Formulas are looking more chaotic with this function and convert to Double value, but i hope this is fine.