Hi everyone!

As a former PM/Designer, I have no industry coding experience - and I've come to realize that my code organization skills are horrible.

I have a SwiftUI view similar to the example below (but far worse), where I have 5-6 if-else statements to validate if certain properties are loaded before presenting the final views.

Somebody suggested that I write helper functions to make it more readable, but then with so many environmentObjects to pass and use in each view, I found that passing classes as objects in helper functions makes it just as complex as simply using nested if loops.

So in a scenario where you have multiple managers to pass around views (like the example below) what would be the best inudstry-convention to fix the pyramid of doom?

import SwiftUI

struct ContentView: View {
    @StateObject var managerA = ManagerA()
    @StateObject var managerB = ManagerB()
    @StateObject var managerC = ManagerC()

    var body: some View {

        if let propertyA = managerA.property {
            if let propertyB = managerB.property {
                if let propertyC = managerC.property {
                    TabView {
                        ViewA()
                        ViewB()
                        ViewC()
                    }
                    .environmentObject(managerA)
                    .environmentObject(managerB)
                    .environmentObject(managerC)
                } else {
                    LoadingView()
                        .task {
                            do {
                                try await self.managerC.getC()
                            } catch {
                                print(error)
                            }
                        }
                }
            } else {
                LoadingView()
                    .task {
                        do {
                            try await self.managerB.getB()
                        } catch {
                            print(error)
                        }
                    }
            }
        } else {
            LoadingView()
                .task {
                    do {
                        try await self.managerA.getA()
                    } catch {
                        print(error)
                    }
                }
        }
    }
}

I don't know if this helps?

Here are a few lines of code. Please note how the Designer and the PM work independently. Don't ask the Designer to put business rules in the views. Don't ask the PM to make design decisions. Keep those roles separate as best you can.

class Manager: ObservableObject, Identifiable {
    // PM: This is where all the business rules for
    // Managers belong. The Designer should NOT need to know the rules.
    // The Designer just needs to know how to call Manager functions or
    // how to access Manager data.

    var id = UUID() // Identify each manager uniquely
    @Published var name : String
    @Published var team : String

    init( newManager: String, newTeam: String) {
        name = newManager
        team = newTeam
    }

    // PM defines the rules for changing a manager's team.
    // This is a business rule. It belongs here.
    // It does NOT BELONG in the VIEW code.
    func changeTeam() {
        team = team.split(separator: " ")[0] + " \(Int.random(in: 10...19))"
    }

    // create new managers for testing
    static var managerA = Manager(newManager: "Rey", newTeam: "Rogue 1")
    static var managerB = Manager(newManager: "Han", newTeam: "Falcon" )
}

struct Pyramid: View {
    // The PM starts this task by stating
    // Today, we will be working with these two manager objects.
    // Later, we may add several more managers.
    @StateObject var managerA = Manager.managerA
    @StateObject var managerB = Manager.managerB

    // DESIGNER says: Hand the manager objects to me and
    // I'll lay them out according to these DESIGN rules.
    @State private var selectedManager = Manager.managerA.id
    var body: some View {
        // SwiftUI is declarative.
        // DECLARE what you want to see.
        TabView(selection: $selectedManager) {
            ManagerView(withManager: managerA )
                .tabItem {
                    Label(managerA.name, systemImage: selectedManager == managerA.id ? "figure.wave" : "figure.stand")
                }
                .tag(managerA.id)
            ManagerView(withManager: managerB )
                .tabItem {
                    Label(managerB.name, systemImage: selectedManager == managerB.id ? "figure.wave" : "figure.stand")
                }
                .tag(managerB.id)
            }
    }
}

// DECLARE what you want to see using a Manager Object
struct ManagerView: View {
    // The PM hands the Designer a manager object....
    @ObservedObject var withManager: Manager

    // The Designer does this with the object....
    var body: some View {
        VStack(spacing: 10.0) {
            Text( withManager.name ).font(.largeTitle).foregroundColor(.indigo)
            Text( withManager.team ).font(.subheadline).fontWeight(.bold).foregroundColor(.gray)
                .padding(.bottom)
            Button("Change Team") {
                // Designer should NOT list the steps here in a view!
                // Designer should CALL the business rule and just handle the results.
                withManager.changeTeam() // <- call the rules in the Manager class!
                // Do NOT put business rules here...
                // NO! // withManager.team = withManager.team.split(separator: " ")[0] + " \(Int.random(in: 10...19))"
            }
        }
    }
}

I think your code will be more Swifty if you consider moving your business code OUT of the views. Put your PM skills to work and move the business functions OUT OF the view code.

@Obelix to the rescue again! Thank you for the words of wisdom that I will carry for a long time to come.

Although bringing up that I'm an ex-product manager helped me get an answer with great insights, I think it also might have de-focused from what I wanted to ask (apart from my sample code being a little too vague). By "manager" in my sample code, I simply meant a helper class like "LocationManager", not in terms of a role 'manager'!

I tried extending this thread, but since the response Obelix gave is a different type of "solution", I will post another question with a more detailed sample code. Thank you!